quran / quran_android

a quran reading application for android
http://android.quran.com
GNU General Public License v3.0
2.01k stars 888 forks source link

Replace Arabic with "Simple" with tashkeel #721

Closed asyazwan closed 5 years ago

asyazwan commented 7 years ago

18:10 from Sr. Alida Ayub via email on 04-12-2016

Problem:

إِذْ أَوَى الْفِتْيَةُ إِلَى الْكَهْفِ فَقَالُوا رَبَّنَا آتِنَا مِنْ لَدُنْكَ رَحْمَةً وَهَيِّئْ لَنَا مِنْ أَمْرِنَا رَشَدًا

Should be:

إِذْ أَوَى الْفِتْيَةُ إِلَى الْكَهْفِ فَقَالُوا رَبَّنَا آتِنَا مِن لَّدُنكَ رَحْمَةً وَهَيِّئْ لَنَا مِنْ أَمْرِنَا رَشَدًا

Reason:

Missing ـّ in مِنْ لَدُنْكَ. See tanzil.

Fix (quran.ar.db):

UPDATE `arabic_text`
SET `text` = "إِذْ أَوَى الْفِتْيَةُ إِلَى الْكَهْفِ فَقَالُوا رَبَّنَا آتِنَا مِن لَّدُنكَ رَحْمَةً وَهَيِّئْ لَنَا مِنْ أَمْرِنَا رَشَدًا"
WHERE `sura` = 18 AND `ayah` = 10
ahmedre commented 7 years ago

jazakAllah khairan for the report.

so i investigated a little bit, and this one specifically seems to be because i am using tanzil's "Simple (plain)" setting instead of "Simple" setting (under the "Quran" checkbox).

if we're fixing this, we should just replace quran.ar.db to use the text contents of Simple instead of Simple Plain instead of just fixing this one case. this is yet another reason to figure out a way to show fonts in the translation areas of the app.

asyazwan commented 7 years ago

What is the reasoning behind using Simple (plain)? It seems to me we should stick as close as possible to the quran text version. So either Uthmani or Simple?

ahmedre commented 7 years ago

i think i was initially worried that there would be things that break with fonts (ex that's why uthmani specifically isn't used since i seem to remember things rendering wrong without proper fonts). we should be able to use Simple instead of Simple Plain.

ahmedre commented 7 years ago

there's actually one more point - simple plain was used for search purposes. in retrospect, that's not right - instead of today's table consisting sura|ayah|text, we should actually have sura|ayah|text|search_text instead. we can use simple plain as search_text and use simple (or even uthmani) as text.

update - i misspoke, we're already doing the right thing here - simple_text is used in the fts backed verses table, whereas the actual text is in the arabic_text table.

ahmedre commented 5 years ago

this is now fixed via #1031