search

quran / quran_android

a quran reading application for android
http://android.quran.com
GNU General Public License v3.0
1.99k stars 886 forks source link

Suggestion: jump to ayah by using EditText instead of drop-down Spinner #799

Closed fikr4n closed 7 years ago

fikr4n commented 7 years ago

السلام عليكم

Is there any planning to change drop-down Spinner of ayah number in "jump to page or surah & ayah" dialog to text field? I think it is easier to type ayah number instead of scrolling in case that the surah is long (has many ayahs). As for the surahs drop-down, how about replacing it with auto-complete text field which also has drop-down (like in the search box at the top bar)?

It's just an idea, based on my experience of a little difficulty when navigating.

fikr4n commented 7 years ago

What I meant was like this. It is only a prototype, of course the code is still dirty.

ozbek commented 7 years ago

Wa alaikum assalam.

Can you clean up the change (eg., remove android.util.Log, commented out code) and send a pull request? It'd be easier to follow your changes that way.

ahmedre commented 7 years ago

wa3laikum alsalam, i think it should be both autocomplete and spinner. walsalam 3alaikum

fikr4n commented 7 years ago

I've created the pull request. Not sure if it is what @ahmedre called "both autocomplete and spinner".

ahmedre commented 7 years ago

jazakAllah khairan