search

qurator-spk / dinglehopper

An OCR evaluation tool
Apache License 2.0
58 stars 12 forks source link

Tests broken, again #102

Closed mikegerber closed 7 months ago

mikegerber commented 8 months ago

https://github.com/qurator-spk/dinglehopper/actions/runs/7285741554/job/19868158221?pr=101

May be because it was a PR.

mikegerber commented 8 months ago

Tests ran fine after merging, so this was something related to that it was a PR.

sadra-barikbin commented 7 months ago

@mikegerber , Failing tests in PRs is seemingly due to the fact that workflows triggered by pull_request event are not granted access to do certain things, e.g. to create checks as does the test-reporter here: https://github.com/qurator-spk/dinglehopper/blob/d3fb3f96cf923e7c1935f4501bd8a949e53abf80/.github/workflows/test.yml#L70-L76

We could add a separate workflow file triggered by workflow_run which could be granted access to create checks and move the above step there. Please see this and this. I would make the PR if you will.

mikegerber commented 7 months ago

@sadra-barikbin Yes, exactly! I will take my time to review this though, dangerous territory ;)

mikegerber commented 7 months ago

Should be fixed with @sadra-barikbin's PR #103, merged in 788868b!