qurator-spk / dinglehopper

An OCR evaluation tool
Apache License 2.0
58 stars 12 forks source link

DeprecationWarning about pkg_resources.declare_namespace #76

Closed kba closed 1 year ago

kba commented 1 year ago

https://github.com/qurator-spk/dinglehopper/blob/bd324331e637fbc4eeff3a9d95c2b94d58b15a28/qurator/__init__.py#L1

I'm getting

DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('qurator')`.
  Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages

for these, consider switching to using implicit PEP420 namespaces?

mikegerber commented 1 year ago

(Edit to fix the link to PEP420)

mikegerber commented 1 year ago

Messing with this stuff feels like computer-aided Jenga, I hope it works 🙏

mikegerber commented 1 year ago

Yeah, it's broken... Should have tested it properly, as installation is broken now.

mikegerber commented 1 year ago

I guess it's OK now.

no idea what i am doing

mikegerber commented 1 year ago

https://github.com/OCR-D/ocrd_all/pull/356#issuecomment-1474492390

The GIF couldn't be truer. It seems this is broken because i.e. eynollah (and probably other packages) uses the old style namespace.

mikegerber commented 1 year ago

Thinking about just ditching the qurator namespace and using "dinglehopper".

mikegerber commented 1 year ago

Reinstalling it makes it broken again...

mikegerber commented 1 year ago

77 has more info of why I didn't notice further breakage.

I'm done for the week and going to fix this on Monday.

mikegerber commented 1 year ago

Reinstalling it makes it broken again...

It was not the reinstalling, but installing without -e that made it break, because then the namespace comes into play.

mikegerber commented 1 year ago

Should be fixed with f668963a2e1fa2f83e44c9dcca666cb98c9a80af