search

qurator-spk / eynollah

Document Layout Analysis
Apache License 2.0
332 stars 27 forks source link

Irritating "Image dimension" log message #55

Closed mikegerber closed 2 years ago

mikegerber commented 2 years ago

I am processing a 4000x6000 image using ocrd-eynollah-segment and get - among other messages - this message:

14:32:10.541 INFO eynollah - Image dimensions: 448x672

Should this read "Patch dimensions" and maybe get a log level of DEBUG?

mikegerber commented 2 years ago

👀 @vahidrezanezhad

kba commented 2 years ago

maybe get a log level of DEBUG?

@vahidrezanezhad knows best about the contents but I converted all the print logging to log.INFO, so it's still visible in a default logging setup. These could certainly be more expressive and/or just be DEBUG stmts.

cneud commented 2 years ago

@vahidrezanezhad Can you please clarify/confirm what is the exact meaning of the log message here, i.e. whether Image dimensions: 448x672 does in fact refer to the size of the patches?

vahidrezanezhad commented 2 years ago

@cneud Yes. They are actually the patch size (input size) of each model.

cneud commented 2 years ago

Thanks. So let's change the log message accordingly for clarity then, ok?

vahidrezanezhad commented 2 years ago

sure

mikegerber commented 2 years ago

It should still be DEBUG not INFO though.

This stuff is important, people read these messages and have to interpret it.

mikegerber commented 2 years ago

I've created PR #71 to downgrade the log message to loglevel DEBUG.