qurator-spk / eynollah

Document Layout Analysis
Apache License 2.0
340 stars 29 forks source link

use PEP420 style qurator namespace #97

Closed kba closed 1 year ago

kba commented 1 year ago

Draft so we can avoid the problems experienced in https://github.com/qurator-spk/dinglehopper/issues/76

cneud commented 1 year ago

Many thanks! This is up on the TODO List, also for https://github.com/qurator-spk/sbb_binarization/issues/50.

cneud commented 1 year ago

(CI fails for 3.8 until https://github.com/qurator-spk/eynollah/pull/91 is merged)

kba commented 1 year ago

CI fails for 3.8 with ValueError: bad marshal data (unknown type code) (https://app.circleci.com/pipelines/github/qurator-spk/eynollah/255/workflows/2e29af30-f9fa-4b0e-9d00-a8ad8c1a6a7f/jobs/267) - what is this about?

cneud commented 1 year ago

This is due to Keras model format using some native Python serialization which is version dependent and was fixed by https://github.com/qurator-spk/eynollah/pull/91 but I believe the CI cache still has the models in the old HDF5 format. So we need to figure out https://github.com/qurator-spk/eynollah/issues/98...

kba commented 1 year ago

This is due to Keras model format using some native Python serialization which is version dependent and was fixed by #91 but I believe the CI cache still has the models in the old HDF5 format. So we need to figure out #98...

Ha, sorry, forgot that was the issue, thanks.