make models (plural) instead of make model

qurator-spk / sbb_binarization

Document Image Binarization

Apache License 2.0

67 stars 14 forks source link

make models (plural) instead of make model #21

Closed cneud closed 3 years ago

cneud commented 3 years ago

Multiple models are indeed used plus this makes naming consistent with other Makefiles.

mikegerber commented 3 years ago

I had a look on other Makefiles to check for consistency:

ocrd_calamari: Uses a different target name
ocrd_tesserocr: Does not have a model download in the Makefile
sbb_textline_detection: Does not have a model download in the Makefile
ocrd_cis: Does not have a model download in the Makefile

So I guess it's up to us how to name this. (There is resource management coming in https://github.com/OCR-D/core/pull/559 but that only pertains to OCR-D.)

cneud commented 3 years ago

I think I checked eynollah for a reference Makefile convention to use.

Moreover, the current version of sbb_binarization does indeed leverage multiple models - btw this it seems is also not properly exposed here.

Anyway I understand that meanwhile @vahidrezanezhad has trained a newer and uniform model so that future versions will only require a single model file...