search

qurator-spk / sbb_binarization

Document Image Binarization
Apache License 2.0
67 stars 14 forks source link

Pinning library versions and adding Python version to README #44

Closed apacha closed 1 year ago

apacha commented 1 year ago

This PR updates the requirements.txt (to pin specifically tested versions that actually work) as well as adding a tested Python version information to the README. Later versions will not work because of loading serialized h5 models causes marshalling errors.

Also adding .idea directory to list of ignored directories.

Fixes #39

mikegerber commented 1 year ago

@kba Pinned versions might be undesirable with ocrd_all, am I right in this assumption?

apacha commented 1 year ago

I can also remove the pin from ocrd

cneud commented 1 year ago

ocrd also includes numpy via ocrd_utils, but deliberately does not pin a version due to different requirements by different TF versions.

mikegerber commented 1 year ago

Side note: For the legacy sbb_textline_detection we had to fix OpenCV to a DIFFERENT version, see https://github.com/qurator-spk/sbb_textline_detection/issues/60

cneud commented 1 year ago

@apacha Thank you again for your contributions! But since the pinning is problematic for OCR-D and the supported Python versions have now been documented in https://github.com/qurator-spk/sbb_binarization/commit/42bca1441cd9535c7af8b98d62eed550bfe3ddd6, I will close here.