search

quri / react-bootstrap-datetimepicker

[DEPRECATED] A react.js datetime picker for bootstrap
http://dev.quri.com/react-bootstrap-datetimepicker/
MIT License
365 stars 292 forks source link

Fix/react 16 update #207

Open brewsoftware opened 6 years ago

brewsoftware commented 6 years ago

This relates to a split in the latest React framework. In React > 15.5 the "PropTypes" library has been broken out of the core framework. In the latest react version 16.0 this means that PropTypes needs to be explicitly imported.

15.5 import React from 'react'

React.PropTypes.func.isRequired

16.0 import React from 'react' import PropTypes from 'prop-types'

PropTypes.func.isRequired

elhay-av commented 6 years ago

Someone going to merge this PR?

chollier commented 6 years ago

no, there is a pretty big notice on the front page in case you missed it: https://github.com/quri/react-bootstrap-datetimepicker#%EF%B8%8F-deprecated-react-bootstrap-datetimepicker

guioconnor commented 6 years ago

It wouldn't be a bad idea to re-publish the package with the deprecation notice, the NPM page doesn't hint at it being deprecated and 27K downloads/month suggest people really are missing the message.