Closed w0nsh closed 3 years ago
@carluri would you be able to take a look at this today?
Hi @w0nsh, I think there is significant interest (see #19) in this. Would it be possible for you to refactor it / add tests? We can then proceed with releasing it once the tests are in,
Hi @w0nsh, I think there is significant interest (see #19) in this. Would it be possible for you to refactor it / add tests? We can then proceed with releasing it once the tests are in,
Okay, done. It should be fixing #19 now
Awesome work @w0nsh! Really cool to see that my linear algebra courses actually came in handy. I've left a few comments and some requests for changes, only minor things really. It all looks good to me though I'm not the most familiar with matrix operations.
Once my comments have been addressed, we can merge this along with #28 and create a new release 🎉
Needed to support DICOMs with different image orientations so I made some small modifications in image_helper. If you'd like to merge it I can refactor the code a bit and add some tests.