Update in ds_helper to support import to Pinnacle

[CaB15]

I have updated the function add_refd_frame_of_ref_sequence in ds_helper to support the import of files into the treatment planning system Pinnacle. There was a note in the code that the previous version should be checked. In Pinnacle, the selection of and random UID for Frame of Reference was not accepted during the import.

[awtkns]

Thanks for this @CaB15! By chance would you be able to add a test for this?

@asim-shrestha I think this looks good to me, thoughts?

[awtkns]

Relates to #29

[CaB15]

Dear Adam,

Sorry, this is the first time I have tried to support a git project. Thus I am not quite sure what you mean by a test. I guess it is something that you should be able to run in the future to test that the code is still producing the expected result. May I ask you to provide some information on examples of tests and how to do that? If so, I might be able to add a test for the support of the project

Best, Carsten

Carsten Brink, Ph.D. Professor og Hospitalsfysiker / Professor and Medical Physicist Klinisk Institut og Radiofysisk laboratorium / Institute of Clinical Research and Laboratory of Radiation Physics Syddansk Universitet og Odense Universitetshospital / University of Southern Denmark and Odense University Hospital DK-5000 Odense C Denmark (Phone (+45) 29 79 64 79 – SMS not possible) e-mail: @.**@.>

From: Adam Watkins @.> Sent: 5. februar 2022 01:55 To: qurit/rt-utils @.> Cc: Carsten Brink @.>; Mention @.> Subject: Re: [qurit/rt-utils] Update in ds_helper to support import to Pinnacle (PR #43)

Thanks for this @CaB15https://github.com/CaB15! By chance would you be able to add a test for this?

@asim-shresthahttps://github.com/asim-shrestha I think this looks good to me, thoughts?

— Reply to this email directly, view it on GitHubhttps://github.com/qurit/rt-utils/pull/43#issuecomment-1030471192, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALUMX5MFSRYV6M5DUQXF6ILUZRYPJANCNFSM5NLT6KTA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.**@.>>

[asim-shrestha]

Hi @CaB15, my apologies for the late response. This looks good! In terms of testing examples, you can view the tests folder to get started. We use a framework called Pytest.

[asim-shrestha]

Updated in #65

Closing