ROI_number attribution - Githubissues

qurit / rt-utils

A minimal Python library to facilitate the creation and manipulation of DICOM RTStructs.

MIT License

181 stars 56 forks source link

ROI_number attribution #78

Open FabienRech opened 1 year ago

FabienRech commented 1 year ago

When trying to automatize addition of ROI in several RTstructure files, one problem is that ROI number in RTstructure might differ and are not successive (sometime going from 10 to 50). Here is a proposition to check if the ROI number exists and give an original ROI number to prevent error in opening of the RT structure in software.

asim-shrestha commented 1 year ago

Hey thanks for tackling this! We should write some tests for this if possible :)

Scenarios:

Adding an roi with no existing ROIs
Adding an roi when there are existing ROI(s) but there is no number conflict
Adding an roi when there are existing ROI(s) but there are number conflicts

asim-shrestha commented 1 year ago

Side note, it looks like some existing unit tests are failing, will need to update those

Also, this looks like it has all of your previous commits that have been merged in, perhaps you need to sync your fork with the mainline repo

FabienRech commented 1 year ago

Thank you for your answer. I will check that in few days, I am not familiar with Github so I could have made a lot of mistakes.