search

quru / qis

Dynamic image server for web and print
https://quruimageserver.com
GNU Affero General Public License v3.0
89 stars 7 forks source link

Base image detection for tiles sometimes seems to fail #21

Closed fozcode closed 6 years ago

fozcode commented 6 years ago

Commit fa583f4e7d1d2461057c1be0309832d19f595fad was to fix groups of warnings in the logs like the one below. But the change made was only appropriate for groups of tiles requested very close together in time. These logs show a gap of nearly 40 seconds while still triggering the old warning, which suggests that _get_base_image() was failing to identify the base image for the tile even after it had been generated. The new code will fix this in _get_tile_base_image() but does not address the underlying problem that _get_base_image() should have found the base image in the first place. Therefore this needs more testing using the image parameters shown below.

2018-11-01 23:10:44,256 qis_16219  WARNING  Tile base generation already performed for 24807277-9-1.jpg IMG:33111,W1160,H1740,Inone,Q75,Krgb,X,D72,E9:16
2018-11-01 23:10:53,958 qis_16215  WARNING  Tile base generation already performed for 24807277-9-1.jpg IMG:33111,W1160,H1740,Inone,Q75,Krgb,X,D72,E11:16
2018-11-01 23:10:59,392 qis_16215  WARNING  Tile base generation already performed for 24807277-9-1.jpg IMG:33111,W1160,H1740,Inone,Q75,Krgb,X,D72,E13:16
2018-11-01 23:11:04,100 qis_16215  WARNING  Tile base generation already performed for 24807277-9-1.jpg IMG:33111,W1160,H1740,Inone,Q75,Krgb,X,D72,E14:16
2018-11-01 23:11:08,483 qis_16215  WARNING  Tile base generation already performed for 24807277-9-1.jpg IMG:33111,W1160,H1740,Inone,Q75,Krgb,X,D72,E15:16
2018-11-01 23:11:12,907 qis_16215  WARNING  Tile base generation already performed for 24807277-9-1.jpg IMG:33111,W1160,H1740,Inone,Q75,Krgb,X,D72,E16:16
2018-11-01 23:11:13,575 qis_16219  WARNING  Tile base generation already performed for 24807277-9-1.jpg IMG:33111,W1160,H1740,Inone,Q75,Krgb,X,D72,E1:16
2018-11-01 23:11:19,291 qis_16215  WARNING  Tile base generation already performed for 24807277-9-1.jpg IMG:33111,W1160,H1740,Inone,Q75,Krgb,X,D72,E2:16
2018-11-01 23:11:23,667 qis_16215  WARNING  Tile base generation already performed for 24807277-9-1.jpg IMG:33111,W1160,H1740,Inone,Q75,Krgb,X,D72,E3:16
2018-11-01 23:11:23,849 qis_16219  WARNING  Tile base generation already performed for 24807277-9-1.jpg IMG:33111,W1160,H1740,Inone,Q75,Krgb,X,D72,E4:16

And another group spread out over nearly 2 minutes:

2018-11-01 22:47:47,890 qis_22804  WARNING  Tile base generation already performed for 24807215-10-1.jpg IMG:29843,W3192,H2256,Q75,Krgb,X,D72,E45:64
2018-11-01 22:47:52,282 qis_22803  WARNING  Tile base generation already performed for 24807215-10-1.jpg IMG:29843,W3192,H2256,Q75,Krgb,X,D72,E52:64
2018-11-01 22:47:52,883 qis_22805  WARNING  Tile base generation already performed for 24807215-10-1.jpg IMG:29843,W3192,H2256,Q75,Krgb,X,D72,E53:64
2018-11-01 22:47:57,465 qis_22803  WARNING  Tile base generation already performed for 24807215-10-1.jpg IMG:29843,W3192,H2256,Q75,Krgb,X,D72,E35:64
2018-11-01 22:47:57,880 qis_22805  WARNING  Tile base generation already performed for 24807215-10-1.jpg IMG:29843,W3192,H2256,Q75,Krgb,X,D72,E43:64
2018-11-01 22:48:02,934 qis_22803  WARNING  Tile base generation already performed for 24807215-10-1.jpg IMG:29843,W3192,H2256,Q75,Krgb,X,D72,E51:64
2018-11-01 22:48:05,110 qis_22805  WARNING  Tile base generation already performed for 24807215-10-1.jpg IMG:29843,W3192,H2256,Q75,Krgb,X,D72,E59:64
2018-11-01 22:48:32,599 qis_22805  WARNING  Tile base generation already performed for 24807215-10-1.jpg IMG:29843,W1732,H1224,Q75,Krgb,X,D72,E11:16
2018-11-01 22:48:32,988 qis_22804  WARNING  Tile base generation already performed for 24807215-10-1.jpg IMG:29843,W6328,H4472,Q75,Krgb,X,D72,E38:64
2018-11-01 22:48:34,575 qis_22804  WARNING  Tile base generation already performed for 24807215-10-1.jpg IMG:29843,W3192,H2256,Q75,Krgb,X,D72,E31:64
2018-11-01 22:48:49,628 qis_22804  WARNING  Tile base generation already performed for 24807215-10-1.jpg IMG:29843,W1732,H1224,Q75,Krgb,X,D72,E12:16
2018-11-01 22:48:50,238 qis_22805  WARNING  Tile base generation already performed for 24807215-10-1.jpg IMG:29843,W1732,H1224,Q75,Krgb,X,D72,E14:16
2018-11-01 22:48:53,542 qis_22804  WARNING  Tile base generation already performed for 24807215-10-1.jpg IMG:29843,W6328,H4472,Q75,Krgb,X,D72,E46:64
2018-11-01 22:49:29,973 qis_22803  WARNING  Tile base generation already performed for 24807215-10-1.jpg IMG:29843,W6328,H4472,Q75,Krgb,X,D72,E28:64
2018-11-01 22:49:30,690 qis_22804  WARNING  Tile base generation already performed for 24807215-10-1.jpg IMG:29843,W6328,H4472,Q75,Krgb,X,D72,E29:64
fozcode commented 6 years ago

I've tested both of these exact scenarios in debug mode and the base images were correctly generated and then identified and used for subsequent tile requests. Closing for now as unable to reproduce.