search

qustavo / dotsql

A Golang library for using SQL.
GNU General Public License v2.0
741 stars 53 forks source link

feature(sqlx): add integration with sqlx #14

Closed hxzhao527 closed 4 years ago

hxzhao527 commented 6 years ago

I'm not sure whether this is the proper way to integrate with sqlx.

In my opinion, implement sql.DB or sqlx.DB interface maybe more elegant. :joy: but that will change the whole project.

hxzhao527 commented 6 years ago

not good enough, I will find a better way to implement this.

davehowell commented 5 years ago

I like that dotsql is a fairly simple wrapper over database/sql, and this PR looks the same over sqlx. It would be great to merge this in the meantime, and get access to useful things like the Select and easy prepared statements, even if you want to spend time doing something to switch out sql.DB or sqlx.DB later.

qustavo commented 5 years ago

I like it as well. @hxzhao527 what would you change to make it good enough?

hxzhao527 commented 5 years ago

:joy: emmm, so sorry, I forgot what I want.