search

qustavo / sqlhooks

Attach hooks to any database/sql driver
MIT License
652 stars 44 forks source link

Add lint ci #49

Closed ehrktia closed 1 year ago

ehrktia commented 2 years ago

add lint to ci

qustavo commented 2 years ago

hey, thanks for this but it looks like in your last commit you've removed the linting instructions (?)

ehrktia commented 2 years ago

Hi @qustavo ,yes I tried to have both lint and test in same action as multiple steps then moved it to separate using existing lint.yml. This is because of the best practise suggested by the golang-ci lint official action.

qustavo commented 2 years ago

Hi @qustavo ,yes I tried to have both lint and test in same action as multiple steps then moved it to separate using existing lint.yml. This is because of the best practise suggested by the golang-ci lint official action.

Are you sure that the lint.yml has been committed and pushed, I can't see it on your PR.

ehrktia commented 2 years ago

Hi @qustavo ,yes I tried to have both lint and test in same action as multiple steps then moved it to separate using existing lint.yml. This is because of the best practise suggested by the golang-ci lint official action.

Are you sure that the lint.yml has been committed and pushed, I can't see it on your PR.

https://github.com/qustavo/sqlhooks/pull/49/commits/029a9f2ad5b1e5d9f2903de166530a1fe596371a commit has lint.yml with one change in to include pull and push.

qustavo commented 2 years ago

For some reason I can't see that commit on this PR Screenshot_2021-12-29_09-41-48

I also noticed that sqlhooks already has a lint.yml (added here: https://github.com/qustavo/sqlhooks/commit/6d849c52e98a5bb2c77700e82c40c90492201fc1), so maybe we should close the issue and this pr?

ehrktia commented 2 years ago

For some reason I can't see that commit on this PR Screenshot_2021-12-29_09-41-48

I also noticed that sqlhooks already has a lint.yml (added here: 6d849c5), so maybe we should close the issue and this pr?

sorry for delay in reply, am able to see the commit in the PR .https://github.com/qustavo/sqlhooks/pull/49/commits/029a9f2ad5b1e5d9f2903de166530a1fe596371a

qustavo commented 2 years ago

anyway, there is already linting support on the current pipeline, what's missing that you'd like to change?