Avoid creating QNetworkAccessManager with QtWebEngine

qutebrowser / qutebrowser

A keyboard-driven, vim-like browser based on Python and Qt.

https://www.qutebrowser.org/

GNU General Public License v3.0

9.48k stars 1.01k forks source link

Avoid creating QNetworkAccessManager with QtWebEngine #2543

Open The-Compiler opened 7 years ago

The-Compiler commented 7 years ago

With #2328 we're probably not going to need a QNAM anymore at all with QtWebEngine, but even before that, we should avoid creating it if we don't actually need it.

This will help avoid bugs like QTBUG-58541 (causing segfaults for various users) or QTBUG-40332.

The-Compiler commented 4 years ago

Has anyone seen the "running qutebrowser causes a higher ping" issue with the last couple of Qt versions (probably anything newer than Qt 5.10)?