search

qutebrowser / qutebrowser

A keyboard-driven, vim-like browser based on Python and Qt.
https://www.qutebrowser.org/
GNU General Public License v3.0
9.6k stars 1.01k forks source link

TypeError when disconnecting contentsSizeChanged when hinting #263

Closed The-Compiler closed 9 years ago

The-Compiler commented 9 years ago

report: http://paste.the-compiler.org/view/714fd4e6

On 8246e94, Qt 5.3.1, runtime: 5.3.2, PyQt 5.3.2

==== Exception ====
Traceback (most recent call last):
  File "/usr/lib/python3.4/site-packages/qutebrowser/browser/hints.py", line 762, in on_mode_left
    self._cleanup()
  File "/usr/lib/python3.4/site-packages/qutebrowser/browser/hints.py", line 150, in _cleanup
    f.contentsSizeChanged.disconnect(self.on_contents_size_changed)
TypeError: disconnect() failed between 'contentsSizeChanged' and 'on_contents_size_changed'

log:

commands   command:run:463 command called: hint
commands   command:run:477 Calling qutebrowser.browser.hints.HintManager.start(<qutebrowser.browser.hints.HintManager object at 0xa6258224>, <Group.all: 1>, <Target.normal: 1>)
misc       message:set_text:228 Follow hint...
hints      hints:_connect_frame_signals:483 Connecting frame <PyQt5.QtWebKitWidgets.QWebFrame object at 0xa88b6dac>
hints      hints:_connect_frame_signals:483 Connecting frame <PyQt5.QtWebKitWidgets.QWebFrame object at 0xa7deb7c4>
[...]
keyboard   basekeyparser:_debug_log:103 Definitive match for 'kj'.
hints      hints:_click:351 Clicking on 'ROM Search Results for "pokemon" - CoolROM.com' at 337/135
[...]
modes      modeman:leave:323 Leaving mode KeyMode.hint (reason: followed), new mode stack [<KeyMode.normal: 1>]
hints      hints:_cleanup:147 Disconnecting frame <PyQt5.QtWebKitWidgets.QWebFrame object at 0xa6287ecc>
misc       app:_exception_hook:466 Uncaught exception
The-Compiler commented 9 years ago

When I reproduce this, the disconnected frame has the same id as the connected ones - here they seem different.

ghost commented 9 years ago

I'm the one who sent the crash report. I tried to replicate it three times and it didn't crash. I thought it might have been something with memory management, like a one-time crash, and it seems to be so. However, I've found another issue; whenever I try to log in into windows live it returns an SSL handshake failure. It doesn't really affect me - I don't use live - but I was able to log in perfectly from firefox. I'm gonna take the opportunity to thank you; I've been wanting a lightweight browser with native vi-style keybinds and so far it has been great. You're doing great work - keep it up!

The-Compiler commented 9 years ago

Added a workaround so this shouldn't crash anymore.

Regarding the SSL issue, it seems like your system's SSL certificates don't contain the certificate for that - it'll probably happen with anything else using system certificates, like wget.

A solution would be to ship our own copy of certificates like Firefox/Chrome do, but I don't really feel comfortable with that yet, as I want to know the exact implications first. You can do :set network ssl-strict false to turn off certificate validation, but I'd advice not doing that until domain-wide preferences are implemented.

Thanks for the motivation, really needed that after struggling with many weird bugs yesterday and today :laughing:! Always happy to hear more about what people think about it. How did you find out about it, by the way?

ghost commented 9 years ago

I found out about it on a "grid" thread over at 8chan.co, where people post what they use as OS, video player, browser, etc. One dude had qutebrowser on his post and i looked it up in the Arch AUR. The browser has been great, can not wait for more features! If i was anywhere near decent at coding I'd contribute, but I can barely do java :p

Thanks for the quick replies, i'll definitely recommend this to my two geeky friends, one of them uses vim regularly and the other one is even newer than I am so he'll surely be into something like this. Good luck squashing the bugs!

On 15 November 2014 20:10, Florian Bruhin notifications@github.com wrote:

Added a workaround so this shouldn't crash anymore.

Regarding the SSL issue, it seems like your system's SSL certificates don't contain the certificate for that - it'll probably happen with anything else using system certificates, like wget.

A solution would be to ship our own copy of certificates like Firefox/Chrome do, but I don't really feel comfortable with that yet, as I want to know the exact implications first. You can do :set network ssl-strict false to turn off certificate validation, but I'd advice not doing that until domain-wide preferences are implemented.

Thanks for the motivation, really needed that after struggling with many weird bugs yesterday and today [image: :laughing:]! Always happy to hear more about what people think about it. How did you find out about it, by the way?

— Reply to this email directly or view it on GitHub https://github.com/The-Compiler/qutebrowser/issues/263#issuecomment-63196860 .

ghost commented 9 years ago

The thread in question was this one https://8chan.co/tech/res/40387.html, on post 41201, by the way. [?]

On 15 November 2014 20:18, Cristian Soria sbcristiansoria@gmail.com wrote:

I found out about it on a "grid" thread over at 8chan.co, where people post what they use as OS, video player, browser, etc. One dude had qutebrowser on his post and i looked it up in the Arch AUR. The browser has been great, can not wait for more features! If i was anywhere near decent at coding I'd contribute, but I can barely do java :p

Thanks for the quick replies, i'll definitely recommend this to my two geeky friends, one of them uses vim regularly and the other one is even newer than I am so he'll surely be into something like this. Good luck squashing the bugs!

On 15 November 2014 20:10, Florian Bruhin notifications@github.com wrote:

Added a workaround so this shouldn't crash anymore.

Regarding the SSL issue, it seems like your system's SSL certificates don't contain the certificate for that - it'll probably happen with anything else using system certificates, like wget.

A solution would be to ship our own copy of certificates like Firefox/Chrome do, but I don't really feel comfortable with that yet, as I want to know the exact implications first. You can do :set network ssl-strict false to turn off certificate validation, but I'd advice not doing that until domain-wide preferences are implemented.

Thanks for the motivation, really needed that after struggling with many weird bugs yesterday and today [image: :laughing:]! Always happy to hear more about what people think about it. How did you find out about it, by the way?

— Reply to this email directly or view it on GitHub https://github.com/The-Compiler/qutebrowser/issues/263#issuecomment-63196860 .