Dynamic dark mode - Githubissues

qutebrowser / qutebrowser

A keyboard-driven, vim-like browser based on Python and Qt.

https://www.qutebrowser.org/

GNU General Public License v3.0

9.45k stars 1.01k forks source link

Closed The-Compiler closed 1 month ago

The-Compiler commented 1 month ago

todo:

[x] ~~Simplify _Definition by using a dict for _settings~~
[x] Maybe unit tests for the _Definition.with_... stuff
[x] Probably will need to adjust unit tests for the changes in darkmode.py
[x] ~~Have an end2end test for this maybe, since we already have dark mode end2end tests in test_invocations.py~~ doesn't really fit in there nicely, but the existing test will already test the runtime switching at startup
[x] Changelog
[x] Whatever CI comes up with

darkmode

rnhmjoj commented 1 week ago

preferred_color_scheme still requires a restart, right?

The-Compiler commented 1 week ago

preferred_color_scheme still requires a restart, right?

Correct. Nothing we can do about that at the moment, as it's only exposed as a CLI argument, not Qt setting.