search

qutebrowser / qutebrowser

A keyboard-driven, vim-like browser based on Python and Qt.
https://www.qutebrowser.org/
GNU General Public License v3.0
9.45k stars 1.01k forks source link

Drop macOS 11 Big Sur - no longer supported by GitHub actions #8207

Open toofar opened 1 month ago

toofar commented 1 month ago

GitHub will be removing their macos-11 images at the end of June: https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/

Since we switched to building releases via GitHub actions for the 3.0.0 release that means we won't be able to provide releases for that macOS version anymore. That's based on the assumption that you can't run builds targeted at newer releases on older ones, which from past discussions of dropping macOS versions is how I understand it.

The supported runner images are listed here: https://github.com/actions/runner-images?tab=readme-ov-file#available-images

So unless anyone has a different plan the work required for this is:

  1. in ci.yaml replace macos-12 with macos-13
  2. replace any macos-11 tags in the workflow files with macos-12
  3. (optional) consider adding a macos-14 CI job, although since that uses apple silicon it might be a bit more complicated and should be spun out to a separate ticket if so (see https://github.com/qutebrowser/qutebrowser/issues/6478 for some related discussions)
  4. make sure all the non-flaky tests pass
  5. run the nightly CI job on your branch and make sure the application starts on mac and basic functionality works

Previous issues about dropping macOS versions for reference (which was back when releases where built on a rented bare metal device): https://github.com/qutebrowser/qutebrowser/issues/5115 and https://github.com/qutebrowser/qutebrowser/issues/7092

:question: One question I have is regarding the upcoming 3.2.0 release. If we are going to be unable to build patch releases for it after a month, should we try to switch to macos-12 ahead of this release?

Edit: looks like ubuntu-24.04 is available too, maybe we can add a CI job for that too while we are in yaml land

The-Compiler commented 1 month ago

Sounds good to me. Thanks for keeping track of this, wasn't on my radar so far!

I'd say let's keep it in for 3.2.0. It sounds like we should get a 3.2.1 in in time. After GitHub drops it, we might as well just make the next release 3.3.0. I'd rather have a 3.3.0 with only minor changes (and then dropping macOS 11 there) rather than dropping it for 3.2.0 already.