search

qutebrowser / qutebrowser

A keyboard-driven, vim-like browser based on Python and Qt.
https://www.qutebrowser.org/
GNU General Public License v3.0
9.45k stars 1.01k forks source link

Issues with Qt 6.8 #8242

Open The-Compiler opened 1 week ago

The-Compiler commented 1 week ago

Qt 6.8 Beta 1 [was released]. Doing the usual dance to get wheels:

mkdir wheels-68
cd wheels-68
python3 -m venv .venv
.venv/bin/pip install pyqt-builder
.venv/bin/pip download --no-deps PyQt6 PyQt6-WebEngine
.venv/bin/pyqt-bundle --verbose --ignore-missing --qt-dir ~/proj/qt/bin6/6.8.0/gcc_64 PyQt6-6.7.0-1-cp38-abi3-manylinux_2_28_x86_64.whl
.venv/bin/pyqt-bundle --verbose --ignore-missing --qt-dir ~/proj/qt/bin6/6.8.0/gcc_64 PyQt6_WebEngine-6.7.0-cp38-abi3-manylinux_2_28_x86_64.whl
rm PyQt6-6.7.0-1-cp38-abi3-manylinux_2_28_x86_64.whl PyQt6_WebEngine-6.7.0-cp38-abi3-manylinux_2_28_x86_64.whl
cd ../git
python3 scripts/mkvenv.py --dev --venv-dir .venv-qt68 --pyqt-type wheels --pyqt-wheels-dir ../wheels-68

Once again leads to a missing symbol....

==================== Running Qt smoke test ====================
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/florian/proj/qutebrowser/git/qutebrowser/qt/widgets.py", line 24, in <module>
    from PyQt6.QtWidgets import *
ImportError: /home/florian/proj/qutebrowser/git/.venv-qt68/lib/python3.12/site-packages/PyQt6/QtGui.abi3.so: undefined symbol: _ZN11QPageLayout15setBottomMarginEd, version Qt_6

which is: QPageLayout::setBottomMargin(double)

The-Compiler commented 1 week ago

Broken ABI

[QTBUG-126454] [REG 6.7 -> 6.8] Broken ABI due to missing QPageLayout::setBottomMargin(qreal) - Qt Bug Tracker

Edit: Ah, already fixed in Beta 2: [QTBUG-126374] ABI break in 6.8 beta 1: QPageLayout::setBottomMargin(double) - Qt Bug Tracker

The-Compiler commented 1 week ago

Missing security patch version in our dict

__________ TestWebEngineVersions.test_chromium_security_version_dict ___________

self = <test_version.TestWebEngineVersions object at 0x7ff5b9f9b8c0>
qapp = <PyQt6.QtWidgets.QApplication object at 0x7ff5c1759b30>

    def test_chromium_security_version_dict(self, qapp):
        """Check if we infer the QtWebEngine security version properly.

        Note this test mostly tests that our overview in version.py (also
        intended for human readers) is accurate. The code we call here is never
        going to be called in real-life situations, as the API is available.
        """
        try:
            from qutebrowser.qt.webenginecore import (
                qWebEngineVersion,
                qWebEngineChromiumSecurityPatchVersion,
            )
        except ImportError:
            pytest.skip("Requires QtWebEngine 6.3+")

        inferred = version.WebEngineVersions.from_webengine(
            qWebEngineVersion(), source="API")
>       assert inferred.chromium_security == qWebEngineChromiumSecurityPatchVersion()
Error: E       AssertionError: assert None == '122.0.6261.128'
E        +  where None = WebEngineVersions(webengine=VersionNumber(6, 8), chromium=None, source='API', chromium_security=None, chromium_major=None).chromium_security
E        +  and   '122.0.6261.128' = <built-in function qWebEngineChromiumSecurityPatchVersion>()

But QtWebEngine infos seem to be outdated, currently claiming the same as Qt 6.7 both in CHROMIUM_VERSION as well as in code:

QtWebEngine 6.8
  based on Chromium 118.0.5993.220
  with security patches up to 122.0.6261.128 (plus any distribution patches)
  (source: api)
The-Compiler commented 1 week ago

TestSavefileOpen.test_failing_flush failing

tests/unit/utils/test_qtutils.py:498: Failure: Qt messages with level WARNING or above emitted
----------------------------- Captured Qt messages -----------------------------
QtWarningMsg: QSaveFile::commit: File (/tmp/pytest-of-user/pytest-0/test_failing_flush0/foo) is not open

probably just a new warning from Qt we can suppress for that test?

The-Compiler commented 1 week ago

Permission caching/saving breaks tests

Error: FAILED tests/end2end/features/test_prompts_bdd.py::test_async_question_interrupted_by_async_one - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'message': 'Asking question *'}.
Error: FAILED tests/end2end/features/test_prompts_bdd.py::test_async_question_interrupted_by_blocking_one - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'message': 'Asking question *'}.
Error: FAILED tests/end2end/features/test_prompts_bdd.py::test_geolocation_with_ask__false - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'message': 'Asking question *'}.
Error: FAILED tests/end2end/features/test_prompts_bdd.py::test_geolocation_with_ask__false_and_save - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'message': 'Asking question *'}.
Error: FAILED tests/end2end/features/test_prompts_bdd.py::test_geolocation_with_ask__abort - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'message': 'Asking question *'}.
Error: FAILED tests/end2end/features/test_prompts_bdd.py::test_always_rejecting_notifications - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'category': 'js', 'message': '[*] notification permission denied'}.
Error: FAILED tests/end2end/features/test_prompts_bdd.py::test_always_accepting_notifications - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'category': 'js', 'message': '[*] notification permission granted'}.
Error: FAILED tests/end2end/features/test_prompts_bdd.py::test_notifications_with_ask__false - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'message': 'Asking question *'}.
Error: FAILED tests/end2end/features/test_prompts_bdd.py::test_notifications_with_ask__false_and_save - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'message': 'Asking question *'}.
Error: FAILED tests/end2end/features/test_prompts_bdd.py::test_notifications_with_ask__true - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'message': 'Asking question *'}.
Error: FAILED tests/end2end/features/test_prompts_bdd.py::test_notifications_with_ask__true_and_save - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'message': 'Asking question *'}.
Error: FAILED tests/end2end/features/test_prompts_bdd.py::test_answering_notification_after_closing_tab - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'message': 'Asking question *'}.
Error: FAILED tests/end2end/features/test_prompts_bdd.py::test_interrupting_ssl_prompt_during_a_notification_prompt - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'message': 'Asking question *'}.

e.g.:

----> Waiting for 'Asking question *' in the log
[...]
  07:58:57.045 DEBUG    webelem    webelem:click:411 Clicking <qutebrowser.browser.webengine.webengineelem.WebEngineElement html='<input type="button" onclick="get_notification_permission()" value="Get notification permission" id="button">'> with click_target ClickTarget.normal, force_event False
[...]
  07:58:57.060 DEBUG    js         shared:javascript_log_message:190 [http://localhost:59211/data/prompt/notifications.html:28] [FAIL] unknown initial value for Notification.permission: granted

probably due to:

Added QWebEngineProfile::setPersistentPermissionsPolicy() to control how website permissions persist across browsing sessions. By default, incoming permissions are saved to disk.

I suppose we'll need at least a -D flag (or maybe even a setting?) to set that to NoPersistentPermissions (?) for tests.

The-Compiler commented 6 days ago

Not much more we can do for Beta 1, I suppose:

I guess we could still investigate the QSaveFile thing in the meantime. Beta 2 will be out on July 17th, though I'll be on holidays then and back on the 29th.

toofar commented 3 days ago

I've pushed some commits to silence the failing tests (not actual fixes) for now, and dug into the persistent permissions feature a tiny bit.

Missing security patch version in our dict

I just set the version numbers to what Qt is reporting. Even though it is incorrect 1) the test is green now for people raising PRs 2) it'll go red again when things next change, hopefully to be more correct https://github.com/qutebrowser/qutebrowser/commit/52632d0f994edbf8682e76790142007ac026cfd2

TestSavefileOpen.test_failing_flush failing

I just ignored the new warning message for that specific test. The test is deliberately trying to provoke this situations, so the warning is correct. https://github.com/qutebrowser/qutebrowser/commit/9ffa98535f7465cb3f93db5fb5b1beab2769813c

Permission caching/saving breaks tests

This is the more complicated one. It's a new feature in webengine that can remember the feature permissions you grant or deny. By default it remembers the permissions you grant per origin both on disk and in memory. This differs from our current behaviour in that we don't remember selections in memory and we only save to disk when the user chooses to.

For now I've just skipped the failing tests, but I think we are going to have to do proper adaptations to this feature for the following reasons:

  1. It's on by default, and as mentioned above will change our default behavior. Until PyQt updates to include the new 6.8 APIs (which can take anything from a week to a month or more) we cannot turn it off. Users are likely to have Qt6.8 with PyQt6.7 which means permissions grants will be remembered when they weren't before.
  2. The persistence mechanism doesn't respect the APIs we use to separate basedirs, which means permission grants will leak between basedirs. Hopefully they fix this one, I've raised a bug ticket here: https://bugreports.qt.io/browse/QTBUG-126595

https://github.com/qutebrowser/qutebrowser/commit/39f8ce51309b24b86c95002c4cca730ce26f39e5 then https://github.com/qutebrowser/qutebrowser/commit/68755ed850b1d41d488e86bf2c6f988b69b8bef3