Deprecate Comparable - Githubissues

qutech / qupulse

Quantum Computing Toolkit for Qubit Control

56 stars 31 forks source link

Closed terrorfisch closed 5 months ago

terrorfisch commented 5 months ago

Deprecate comparable because it is "unpythonic" and makes comparisons hard to follow.

Three subclasses have been changed:

AWG now directly implements an id based hash and comparison.
Waveform is now compared and hashed based on the __slots__ and _duration of the base class by default. TransformingWaveform overrides that because it caches results for more efficient multi channel sampling.
Transformation implementations now provide there own __eq__ and __hash__.

terrorfisch commented 5 months ago

@Nomos11 Do you thiunk this is reasonable?

github-actions[bot] commented 5 months ago

6 files 6 suites 4m 58s :stopwatch: 1 210 tests 1 142 :white_check_mark: 68 :zzz: 0 :x: 7 260 runs 6 852 :white_check_mark: 408 :zzz: 0 :x:

Results for commit fc0e5e76.

:recycle: This comment has been updated with latest results.

terrorfisch commented 5 months ago

@Nomos11 please merge if you don't have objections

Nomos11 commented 5 months ago

I'm not authorized to merge into master (it's for the better).