search

qutech / qupulse

Quantum Computing Toolkit for Qubit Control
56 stars 31 forks source link

Add atssimple dac support #849

Open maxbeer99 opened 5 months ago

maxbeer99 commented 5 months ago

Resolves #848

github-actions[bot] commented 5 months ago

Test Results

    3 files      3 suites   3m 46s :stopwatch: 1 196 tests 1 135 :white_check_mark:  61 :zzz: 0 :x: 3 588 runs  3 405 :white_check_mark: 183 :zzz: 0 :x:

Results for commit b33b9e67.

:recycle: This comment has been updated with latest results.

maxbeer99 commented 5 months ago

Usage: Jupyter Notebook Example

terrorfisch commented 5 months ago

Optimally include the usage example in doc/source/examples

terrorfisch commented 5 months ago

Code looks good to me

maxbeer99 commented 5 months ago

Note that input range is not yet used to scale results. This needs to be implemented before merge

terrorfisch commented 5 months ago

Shouldn't this be implemented in simpleats itself?

maxbeer99 commented 5 months ago

Shouldn't this be implemented in simpleats itself?

Yes, just forgot to pass required args.

maxbeer99 commented 5 months ago

Note that here I implemented non-blocking acquisition in atssimple directly. Before merge this should be used in qupulse instead of the ad-hoc implementation.

maxbeer99 commented 5 months ago

Note that input range is not yet used to scale results. This needs to be implemented before merge

done

maxbeer99 commented 5 months ago

Note that here I implemented non-blocking acquisition in atssimple directly. Before merge this should be used in qupulse instead of the ad-hoc implementation.

done

maxbeer99 commented 4 months ago

ready to merge btw