qutip / QuantumToolbox.jl

Quantum Toolbox in Julia
https://qutip.org/QuantumToolbox.jl/
BSD 3-Clause "New" or "Revised" License
46 stars 16 forks source link

Normalize states for `mcsolve` solution #213

Closed albertomercurio closed 2 months ago

albertomercurio commented 2 months ago

Description

The current implementation was returning unnormalized states when saveat argument was set. This is different from qutip behavior, where the normalized states are returned.

Here I fix this difference by normalizing the states when generating the solution.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.27%. Comparing base (3d266c0) to head (1726196). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #213 +/- ## ======================================= Coverage 93.27% 93.27% ======================================= Files 29 29 Lines 2172 2172 ======================================= Hits 2026 2026 Misses 146 146 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ytdHuang commented 2 months ago

LGTM !