qutip / qutip-lattice

The QuTiP lattice package
BSD 3-Clause "New" or "Revised" License
5 stars 6 forks source link

lattice.py split into files #8

Closed sbisw002 closed 1 month ago

sbisw002 commented 1 year ago

@Ericgig I addressed the issues raised last time. 1) Split the lattice.py into multiple files. 2) removed duplicate stuff you pointed out.

It works with both qutip 4 and 5, since it is very independent actually.

I am working on a write-up to explain more. Lattice1d is for single particle physics only. The other classes like Lattice1d_fermi_hubbard or Lattice_1d_bose_hubbard are for multi particle physics. The user will only use one of them in their work, like there would not be any mix and match. The only commonality is they are both lattices. But all models are very disparate and user would only import one and work exclusively in one. More details to follow in the write-up.

Example usage can be found at https://github.com/sbisw002/qutip-lattice-notebooks/tree/master

I hope qutip-5 is on track!

Ericgig commented 1 year ago

@sbisw002 Thank you for the PR, but expect this to take a lot of time to review. The PR is quite large and once merged, the qutip team will have to support it and I don't think we can right now. Clements was telling me you were in an hurry, in that case you may want to publish it on your own and not wait for us.

sbisw002 commented 9 months ago

Happy New Year. @Ericgig Thanks for the work. I will wait. Please let me know if I can help. I want to help with the maintenance as well.

sbisw002 commented 7 months ago

@Ericgig , a reminder for this one!

Ericgig commented 7 months ago

I won't be reviewing this:

Does this belong in qutip? It works with numpy arrays more than qutip's Data and Qobj and re-implement qutip's functions. The coding style it different. To me it seems to use Qutip, but not be part of it.