search

qutip / qutip-notebooks

A collection of IPython notebooks using QuTiP: examples, tutorials, development test, etc.
BSD 3-Clause "New" or "Revised" License
235 stars 236 forks source link

Issue #1208 Test #106

Open mlaguna10 opened 4 years ago

mlaguna10 commented 4 years ago

Notebook testing changes made under issue #1208.

Pauli-X, Y, Z and S,T Quantum Gates using QuTiP: new functions added under issue #1208 are documented in this notebook.

review-notebook-app[bot] commented 4 years ago

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

mlaguna10 commented 4 years ago

Hi @nathanshammah, besides applying each change required, I also create a stronger notebook with some more theory about qubits and single-qubit gates. Take a look and let me know what you think.

About adding the link to the tutorials.html doc, it's not possible since this PR has not been merged yet, so the link of the notebook is still in my localhost.

The name of the notebook was also changed to Theory of Qubits and Single Quantum Gates.ipynb.

BoxiLi commented 4 years ago

Sorry for the delay. The notebook looks good! Thanks @mlaguna10.

What I'm not sure about is where shall we put it? As a stand-long notebook, only mentioning the single-qubit gates makes the story kind of incomplete to me. And it partially overlaps with the long notebook of quantum gates Quantum Gates and their usage.

What about

Later, we

What is your mind on this? @nathanshammah @quantshah

mlaguna10 commented 4 years ago

Sorry for the delay. The notebook looks good! Thanks @mlaguna10.

What I'm not sure about is where shall we put it? As a stand-long notebook, only mentioning the single-qubit gates makes the story kind of incomplete to me. And it partially overlaps with the long notebook of quantum gates Quantum Gates and their usage.

What about

  • we merge this notebook first

Later, we

  • Split the long notebook into a gate part and a circuit part
  • Create a more complete story using this notebook and the gate part of the long notebook

What is your mind on this? @nathanshammah @quantshah

That sounds great and I'd love to take care of completing this whole plan. I will be aware of what @nathanshammah and @quantshah think to start working on this.

hodgestar commented 2 years ago

@BoxiLi Just pinging this PR -- should we merge? Not merge?