search

qutip / qutip-notebooks

A collection of IPython notebooks using QuTiP: examples, tutorials, development test, etc.
BSD 3-Clause "New" or "Revised" License
235 stars 236 forks source link

qasm notebook #111

Closed sarsid closed 3 years ago

sarsid commented 4 years ago

As per issue #110, this PR is meant to add examples for QASM import/export. I also plan to add some examples of the particularities of dealing with QISKIT and CIRQ and how they interface with the QASM format. Right now, it only contains reading from QASM files.

review-notebook-app[bot] commented 4 years ago

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

nathanshammah commented 4 years ago

I understood from our latest chat that this is review ready? If so, can you switch from draft PR, @sarsid to just an open one? Or was it another PR?

sarsid commented 4 years ago

Or was it another PR?

Done.

BoxiLi commented 4 years ago

Thanks for the notebook @sarsid ! I left some comments where I find the text a bit confusing.

nathanshammah commented 4 years ago

Just checking in on this PR.

sarsid commented 4 years ago

I made the requested changes. However, given the difference in the run function, I'd want to wait for the circuit_efficiency PR to be merged.

BoxiLi commented 3 years ago

Seems that there are still something missing. I'll merge this first and then collect all the qip stuff to make another PRs.