qutip / qutip-notebooks

A collection of IPython notebooks using QuTiP: examples, tutorials, development test, etc.
BSD 3-Clause "New" or "Revised" License
235 stars 236 forks source link

Piqs Notebooks #53

Closed nathanshammah closed 6 years ago

nathanshammah commented 6 years ago

@ajgpitch Dear Alex, these are the updated notebooks, they run in the merged version of Piqs. The three notebooks are renamed as "piqs_...". I will add more notebooks once we upload the manuscript on the arXiv.

nathanshammah commented 6 years ago

Regarding the last change: Improved readability of markup of equations that now render also on GitHub. Changed definition of g2(tau). Added/changed text.

ajgpitch commented 6 years ago

@nathanshammah I tried running piqs_introduction against the latest qutip/master

I got this error when running In[15]:

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-15-2c02a29de33b> in <module>()
     10 rho7 = np.real(ground_state.full())
     11 rho8 = np.real(subradiant_state.full())
---> 12 rho9 = np.real(dicke_basis.todense())

AttributeError: 'numpy.ndarray' object has no attribute 'todense'

Seems like it should be an easy fix

ajgpitch commented 6 years ago

The notebook is looking generally great btw. Really good work

nathanshammah commented 6 years ago

@ajgpitch Dear Alex, thank you. For some reason I was not getting that error. I changed the name of that variable, as it is also the name of a function and that might give the error. I also enhanced the notebook in several parts. In particular the last subplots now are more compact.

ajgpitch commented 6 years ago

I's still getting the error. I think when you do dicke_blocks = np.real(block_matrix(N)) then np.real converts to a dense matrix, hence dicke_blocks.todense() errors. Maybe it's a numpy version thing. This is my version info

QuTiP Version:      4.3.0.dev0+cdc2204
Numpy Version:      1.12.0
Scipy Version:      0.19.0
Cython Version:     0.25.2
Matplotlib Version: 2.0.0
Python Version:     3.6.0
Number of CPUs:     4
BLAS Info:          INTEL MKL
OPENMP Installed:   False
INTEL MKL Ext:      True
Platform Info:      Linux (x86_64)

I changed to:

dicke_blocks = np.real(block_matrix(N).todense())

...

rho9 = dicke_blocks

and it works fine

ajgpitch commented 6 years ago

Also the final box needs

plt.show()
plt.close()

otherwise no plots

nathanshammah commented 6 years ago

Dear @ajgpitch, I hope now it works fine. My Numpy version is 1.13.3, Scipy 1.0, Matplotlib 2.1.1. Thank you.

QuTiP Version: 4.3.0.dev0+cdc2204a Numpy Version: 1.13.3 Scipy Version: 1.0.0 Cython Version: 0.27.3 Matplotlib Version: 2.1.1 Python Version: 3.6.3 Number of CPUs: 2 BLAS Info: INTEL MKL OPENMP Installed: False INTEL MKL Ext: True Platform Info: Darwin (x86_64)

ajgpitch commented 6 years ago

I have checked all three notebooks. They all work fine and look pretty much ready. Just a few minor points:

In the ...intro... This looks like a mistake (In[20])

rho9 = rho9 = dicke_blocks

In ...steadystate... You need to run the qutip.about() box. Wouldn't normally quibble, but we have to be clear that qutip v4.3 is needed.

nathanshammah commented 6 years ago

Dear Alex, sorry about that. Thanks a lot.

2018-03-20 1:18 GMT+09:00 Alexander Pitchford notifications@github.com:

I have checked all three notebooks. They all work fine and look pretty much ready. Just a few minor points:

In the ...intro... This looks like a mistake (In[20])

rho9 = rho9 = dicke_blocks

In ...steadystate... You need to run the qutip.about() box. Wouldn't normally quibble, but we have to be clear that qutip v4.3 is needed.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/qutip/qutip-notebooks/pull/53#issuecomment-374271573, or mute the thread https://github.com/notifications/unsubscribe-auth/AN5ffDA02APl6-_6ukqwibFqEcMzWq9cks5tf9pogaJpZM4SiLR0 .

ajgpitch commented 6 years ago

Thanks again for these model notebooks