qutip / qutip-qoc

Quantum Optimal Control
BSD 3-Clause "New" or "Revised" License
4 stars 4 forks source link

RL algorithm implementation #19

Closed LegionAtol closed 1 month ago

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 11141454500

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/qutip_qoc/_rl.py 157 168 93.45%
<!-- Total: 162 173 93.64% -->
Files with Coverage Reduction New Missed Lines %
src/qutip_qoc/_optimizer.py 1 85.07%
src/qutip_qoc/_goat.py 1 98.26%
src/qutip_qoc/pulse_optim.py 3 93.68%
<!-- Total: 5 -->
Totals Coverage Status
Change from base Build 9845330822: 1.2%
Covered Lines: 811
Relevant Lines: 915

💛 - Coveralls
flowerthrower commented 1 month ago

@LegionAtol please take one last look at the minor changes I have made.

  1. I reverted to your original solution of using the shorter_pulses kwrd instead of an empty __time__ dict.
  2. I ran pre-commit run -a for proper formatting

Once you sign of on these changes, the PR is ready to merge.

LegionAtol commented 1 month ago

Ok, that's fine thanks Patrick