search

qutip / qutip-tensorflow

TensorFlow linear-algebra backend for QuTiP
BSD 3-Clause "New" or "Revised" License
15 stars 9 forks source link

Functions that lack test in QuTiP. #18

Open AGaliciaMartinez opened 3 years ago

AGaliciaMartinez commented 3 years ago

These are some modules in QuTiP for which there are no tests written yet. I will try to write them since they are very useful to define what an operation should do. This facilitates the development of new data types.

jakelishman commented 3 years ago

I don't know all of them, but off the top of my head, the eigensolvers, ptrace and expect definitely have tests.

AGaliciaMartinez commented 3 years ago

Hey Jake, thanks for pointing out that those test exist as at first I did not look beyond the tests in tests/core/data/! Indeed there is a test_expect.py (and similar for eigensolver and ptrace) in QuTiP but these seem to be testing Qobj level functionality. I was looking for tests similar to those in test_mathematics that I can inherit from and easily employ to test my own specialisations. I think that extending test_mathematics.py to provide tests for the above specialisations would be very useful. This allows QuTiP to define what the specialisations should do in a very concrete way and it helps future developers to develop new data layers.

From the discussion at yesterdays GSoC meeting, it seems that @hodgestar, @Ericgig and @quantshah agree although they suggested to extend test_mathematics in a different file for organization purposes as test_mathematics is already quite big.