qutip / qutip-tensorflow

TensorFlow linear-algebra backend for QuTiP
BSD 3-Clause "New" or "Revised" License
15 stars 9 forks source link

Fixed an issue with matmul and autodiff. #36

Closed AGaliciaMartinez closed 2 years ago

AGaliciaMartinez commented 2 years ago

The problem is that we were taking a fast multiplication for scale==1 but ths means that when the input is a variable, the variable does not get multiplied and causes problems when working with autodiff.

AGaliciaMartinez commented 2 years ago

We have the same problem with all the functions that have scale as argument. I will try to fix it in this PR.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1887339705

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 1550141207: 0.3%
Covered Lines: 370
Relevant Lines: 381

💛 - Coveralls