qutip / qutip-tensorflow

TensorFlow linear-algebra backend for QuTiP
BSD 3-Clause "New" or "Revised" License
15 stars 9 forks source link

Correct QuTiP version specifier #5

Closed jakelishman closed 3 years ago

jakelishman commented 3 years ago

QuTiP installs failed because 5.0.0dev0 is "lower" than 5.0.0a0. This was a bug in the configuration file that was able to slip through because dev.major was still using an old versioning scheme.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 942706993


Totals Coverage Status
Change from base Build 915588242: 0.0%
Covered Lines: 4
Relevant Lines: 4

💛 - Coveralls
coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 942706993


Totals Coverage Status
Change from base Build 915588242: 0.0%
Covered Lines: 4
Relevant Lines: 4

💛 - Coveralls
AGaliciaMartinez commented 3 years ago

Not sure what you mean by installation fail as I did not have any with qutip>=5.0.0.a0. Nevertheless, given that both a0 and dev0 seem to work will merge the change.

AGaliciaMartinez commented 3 years ago

I got the error after pulling from upstream. Will merge now to fix it.