qutterr / keepassdroid

Automatically exported from code.google.com/p/keepassdroid
0 stars 0 forks source link

App throws away unsaved edits on lock timeout #624

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Create a new entry, Save
2. Edit the entry to add fields, etc.
3. Wait for the lock timeout

What is the expected output? What do you see instead?
It's a bit tricky to figure out what the correct behavior should be. Prevent 
the database from locking? Write the unsaved edits to a temporary location 
(recycle bin) and tell the user this happened after they unlock again? The 
current behavior seems wrong, though -- the edits are thrown away.

What version of the product are you using? On what operating system?
Version 1.99.10 on Android KitKat (Asus Nexus 7)

Please provide any additional information below.
Loss of user data is generally a bad thing, but particularly frustrating if 
you've generated a strong password, put it into use, then lost it because the 
application locked before the entry was saved.

Original issue reported on code.google.com by e...@esmithy.net on 3 Dec 2013 at 5:39

GoogleCodeExporter commented 8 years ago
This can be deeply frustrating if you forget to save and then create a new 
account with a strong password that you can't then log into.  

The correct behaviour seems to me to be to store a temporary entry as soon as 
the user moves away from keepassdroid (and regularly during editing).  When the 
user unlocks, if that entry is present then it should be reloaded.

The slight danger would be if the keepass file was edited outside keepassdroid 
and the entry updated separately;  this could be okay if a timestamp is stored 
somewhere and the old entry is only overwritten if the timestamp is the same 
age as the last write to the password file.  

A related *really nice* behavior would be to have a temporary before and after 
for when someone is doing a password change.  

Original comment by mike...@gmail.com on 19 Apr 2014 at 7:26