Submission for assignment 5 - Githubissues

quychi / df-frontend-2023

https://df-frontend-2023-sigma.vercel.app

0 stars 0 forks source link

Submission for assignment 5 #5

Open quychi opened 11 months ago

quychi commented 11 months ago

Link demo: https://main--chic-rugelach-ef93c6.netlify.app/books
Problem: visit the default page (https://main--chic-rugelach-ef93c6.netlify.app/sign-in) to init data and auto redirect to the BookList page (work locally but not on deploy)
Sign In page url: https://main--chic-rugelach-ef93c6.netlify.app/sign-in
Book List page url: https://main--chic-rugelach-ef93c6.netlify.app/books
Book Detail page url: https://main--chic-rugelach-ef93c6.netlify.app/book/[bookId]

tienan92it commented 10 months ago

Hello @quychi , well done!. Below is some feedback for your assignment.

Requirements

[ ] All core functionalities present
[x] Edit form
[x] Login page
[x] Forms built by react-hook-form
[x] Validation by zod
[ ] Bonus: Password Strength Meter

Final result: ✅ passed 80% of requirements

Feedback

Be consistent. If Book validation is defined in _types, SignIn validation should be there too. https://github.com/quychi/df-frontend-2023/blob/5f415072e623345bfe4ca72536771330a336a412/assignment-5/src/app/(routes)/(authentication)/sign-in/page.tsx#L12-L27