search

qvacua / vimr

VimR — Neovim GUI for macOS in Swift
https://twitter.com/VimRefined
MIT License
6.61k stars 218 forks source link

Unsetting custom nvim binary does not work #1022

Closed p3palazzo closed 7 months ago

p3palazzo commented 7 months ago

Expected behavior: Deleting the contents of the Settings > Advanced > Neovim Binary text field should unset the custom nvim binary.

Actual behavior: The settings reverts to the last contents of the Neovim Binary field. Only manually editing the ~/Library/Preferences/com.qvacua.VimR.plist file manages to unset this customization.

Additionally, using the Homebrew nvim binary version 0.9.4 as the custom Neovim Binary does not work and results in a blank window in vimr.

Version 0.45.0 (20231122.130444)

georgeharker commented 7 months ago

Thanks for the report. That should be throwing up an alert saying incompatible version (upstream fixes were needed for this to work which are in newer versions) can you let me know if that alert shows. We will look at why unsettling doesn’t work.

zornme commented 7 months ago

I am having the same issue and wanted to chime in to say that the alert does not show. VimR hangs at load and then after a few seconds displays the blank screen. I've attached a screenshot as well. Thank you for all of your work on this project.

image
p3palazzo commented 7 months ago

Exactly, that's my experience, too. No alert and just the blank window after a few seconds at startup.

qvacua commented 7 months ago

I'm afraid, I cannot reproduce the issue. I'm not sure, but, I made a small change which might fix the issue. Can you please try https://github.com/qvacua/vimr/releases/tag/snapshot%2F20231129.173509 ?

qvacua commented 7 months ago

BTW: @p3palazzo : Which version of macOS are you using?

p3palazzo commented 7 months ago

Ventura with the latest updates applied.

qvacua commented 7 months ago

@p3palazzo : My guess is that I cannot reproduce it due to a subtle difference between macOS versions; I'm on Sonoma. If my guess is right, the new snapshot above should fix the issue: Please try it.

p3palazzo commented 7 months ago

Now it clears the path to the incompatible nvim binary on quit and relaunch, which solves the blank window problem, but still doesn't throw any alert.

georgeharker commented 7 months ago

I’ll take a look at the alert side.

georgeharker commented 7 months ago

I have some fixes for getting an incompatible version alert to show (it's a bit complex as older neovim without the upstream fix we submitted will block io until a connection is made on stdin, but we should have something soon.

qvacua commented 7 months ago

https://github.com/qvacua/vimr/releases/tag/v0.45.1-20231211.195158 contains the fix.