Modify theming code: custom tab theme is now pulled from TablineSel highlight group

qvacua / vimr

VimR — Neovim GUI for macOS in Swift

https://twitter.com/VimRefined

MIT License

6.61k stars 218 forks source link

Modify theming code: custom tab theme is now pulled from TablineSel highlight group #1059

Closed s-daveb closed 1 month ago

s-daveb commented 2 months ago

Fixes the issue raised in #1058 where the everforest theme results in low-contrast tabs, by using color groups that were meant for tabs

Before Screenshot 2024-05-06 at 2 58 17 PM

After Screenshot 2024-05-06 at 2 57 50 PM

qvacua commented 1 month ago

Thank you a log for the PR! However, I noticed that with darker theme, the close button is not visible in the active tab; could you have a look? I'm using https://github.com/dracula/vim .

s-daveb commented 1 month ago

How is this? I tested it with Dracula, and it looks okay.

s-daveb commented 1 month ago

There are still pending problems with themes such as 'Ron' and other dark themes... I'll see if I can find an easy solution

s-daveb commented 1 month ago

Latest code changes have it rendering like this for me, under the 'ron' theme. Does this work for you?

qvacua commented 1 month ago

LGTM!