qvacua / vimr

VimR — Neovim GUI for macOS in Swift
https://twitter.com/VimRefined
MIT License
6.61k stars 218 forks source link

Fix lcd/tcd #1078

Closed shanesmith closed 1 week ago

shanesmith commented 1 week ago

The following code path effectively turned any lcd or tcd into a cd.

This chain had to be broken somewhere. The state.cwdToSet line in MainWindowReducer.swift has a comment that it's set to "ensure updates also send to tab bar". To fix we remove that line and instead set the tab bar cwd earlier in the cahin in NvimView+UiBridge.swift.

I don't normally use the custom tab bar or file browser, but have tested them with this change and they seem to still work well.

Fixes #1027

georgeharker commented 1 week ago

This is fantastic and was also on my list to look at. Thanks!

There was some confusion due to lcd not working right which caused me to make the change. I think it related to the browser not getting updated on tab switch.