search

qvacua / vimr

VimR — Neovim GUI for macOS in Swift
https://twitter.com/VimRefined
MIT License
6.65k stars 218 forks source link

issues with underline and undercurl #839

Open postylem opened 3 years ago

postylem commented 3 years ago

Hi I've just come over from using MacVim, and wanted a similar experience for neovim. VimR is great!

I noticed that the underline and undercurl highlighting are generally too close to the text. I know this might have something to do with fonts, but it seems to be true across fonts for the undercurl, so I think it's a VimR issue. Also, in some fonts (Courier New) adding undercurl seems to change the size too?

VimR, Fira Mono:

vimr-fira_mono

VimR, Andale mono:

vimr-andale_mono

VimR, Courier New (something else odd is happening too, here):

vimr-courer_new

Compare this with MacVim with the same settings (it isn't necessarily perfect, but I think these look nicer):

MacVim, Fira Mono:

macvim-fira_mono

MacVim, Andale mono:

macvim-andale_mono

MacVim, Courier New:

macvim-coureir_new

(Something similar was raised in issue [#817], so I sorry if I'm bringing something up that has been decided against pursuing for a reason, but I didn't see any comments there so thought it may have been resolved, but it doesn't seem so for me)

bfulop commented 1 year ago

I agree with the original post:

I'm using the Iosevka font and find that the underline and undercurl are to close to the text and reducing the readability of it.