search

qvacua / vimr

VimR — Neovim GUI for macOS in Swift
https://twitter.com/VimRefined
MIT License
6.64k stars 218 forks source link

Font color in Preferences doesn't adjust with macOS system wide dark mode #878

Closed NethumL closed 2 years ago

NethumL commented 2 years ago

When setting Dark Mode for the entire OS, VimR activates its dark mode as well. But in Preferences, some of the fonts don't adjust for that. The main ones do (they become white), but the other ones don't.

Steps to reproduce:

  1. Go to macOS System Preferences -> General -> Appearance, and change to Dark mode
  2. Open VimR
  3. Open Preferences

Expected: Font color should become a lighter color, so that it's visible against the dark background Actual: Font color is still black, so it's difficult to read.

I checked whether it had anything to do with my neovim theme. Disabling it didn't have any effect.

I attached screenshots of how it looks in light mode and dark mode respectively.

Light mode:

light-mode

Dark mode:

dark-mode

VimR version: 0.35.0 (20211105.213803) neovim version: 0.5.1 macOS version: 11.6 (x86)

qvacua commented 2 years ago

Currently, VimR does not support dark mode. My assumption is that most Neovim users use custom color scheme anyways. Therefore, it can adapt to the color scheme you have selected in Neovim. Turn on Preferences -> Appearance -> Use Neovim's color scheme for main window and tools.

Closing the issue, however, if you want to discuss this issue further, please use #908.

qvacua commented 2 years ago

The idea proposed in https://github.com/qvacua/vimr/issues/859 is nice. I'll try to implement it.

bronzehedwick commented 2 years ago

859 captures dynamically switching the user Vim theme based on dark/light theme, but does not capture the issue presented here, which is that some text in the Vimr preference pane is still black when in dark mode.

141657642-18262184-3e0f-41e4-9646-f9bc6eaa7771

I think this issue is still valid, and I can replicate on the latest snapshot.

ELLIOTTCABLE commented 2 years ago

I'm seeing this too — and, yeah, it's unrelated to dark-mode support in Vim-proper.

j-rahman commented 1 year ago

Why is this issue closed? I just installed a fresh copy of vimr (v. 0.44.0,20230103.174333) and, since I predominantly use Dark Mode, the Preferences window just looks bad and half-baked because of this unresolved very real issue. Since this app purports to be a native Swift app built for macOS, I would expect it to look more than half decent and to support automatic Dark Mode switching off the shelf. Thank you.