qvacua / vimr

VimR — Neovim GUI for macOS in Swift
https://twitter.com/VimRefined
MIT License
6.64k stars 218 forks source link

feat: add a pref to open files from applications in current window #914

Closed SolaWing closed 2 years ago

SolaWing commented 2 years ago

add a new pref to open file from finder in current window.

closes #680 #642

SolaWing commented 2 years ago

@qvacua thank you for you review.

this pref work on:

  1. drop files on app icon in dock bar.
  2. open files from finder, like open with ... or double click

this pref not work on:

  1. drop files into vimr app window, this always open in current window, and may be a seperate entry api.(I haven't check the code yet, do behaviors need to be unified? )

so it's not just only works for drag drop. for me, I rarely use droping files, most time i just double click files in finder. so limit the tip to drop & drag is not accurate. if you have any more clarity tip, you can comment me.

qvacua commented 2 years ago

Ah, I missed number 2. You're right, sorry about that. What about the following:

As for the drag&drop onto the window, I have to look at it, but anyhow, it can be done separately (if necessary).

SolaWing commented 2 years ago
图片

maybe we can make tip same as macvim, though currently we only support each tab option

drop onto the window, and open in that window, seems like a reasonable behavior . may not need to configure

qvacua commented 2 years ago

The info text of MacVim looks good. Yeah, the additional configuration can be built separately, if needed (I don't need it, but maybe others 😀).

SolaWing commented 2 years ago

@qvacua var and names changes accordings to macvim tip