search

qvacua / vimr

VimR — Neovim GUI for macOS in Swift
https://twitter.com/VimRefined
MIT License
6.64k stars 218 forks source link

Upon switching to Enum we need to get .value #919

Closed archoversight closed 2 years ago

archoversight commented 2 years ago

We need the value not just the enum stringified so that we create a open URL that actually functions correctly.

Without this fix, we would create the following URL (change introduced in: https://github.com/qvacua/vimr/commit/599811e8919d3cd1b00525e1fe1a47fc854f3904)

/usr/bin/open vimr://Action.ACTIVATE?QueryParamKey.PIPE_PATH=%2F%2Fvar%2Ffolders%2F0m%2Fddtqg4z179d4hzmyn5xjb8540000gn%2FT%2Fcom_qvacua_vimr_cli_pipe_8c27798a-2f92-47c5-94e8-bc6eb1325d01&QueryParamKey.CWD=%2FUsers%2Fc5309377%2FProjects%2Fmy-terraform

After this fix:

/usr/bin/open vimr://activate?pipe-path=%2F%2Fvar%2Ffolders%2F0m%2Fddtqg4z179d4hzmyn5xjb8540000gn%2FT%2Fcom_qvacua_vimr_cli_pipe_0e64328e-f601-4368-aa3b-a480c7e5a3f2&cwd=%2FUsers%2Fc5309377%2FProjects%2Fmy-terraform

Fixes #918

qvacua commented 2 years ago

Thanks!