qvacua / vimr

VimR — Neovim GUI for macOS in Swift
https://twitter.com/VimRefined
MIT License
6.62k stars 218 forks source link

Pre-release 0.8 builds don't work correctly with fzf-lua previews #984

Open andrewferrier opened 1 year ago

andrewferrier commented 1 year ago

Apologies, I haven't had time to fully look into this issue yet and create a minimal repro, but am opening this anyway in case it's easily reproducible by you.

I use fzf-lua fairly extensively with NeoVim. With 0.8 or nightly in the terminal, it works as expect. With VimR 0.7, it worked well. However, with VimR 0.8 nightly (showing as NVIM v0.9.0-dev-nvimserver-0.7.0-0-54-gb3f42c717), I get lots of issues with fzf-lua. In particular, in the pop up windows, previews don't display (:Fzf files is an easy way to see this). I see the same problems with many other Fzf commands.

I wonder if something has changed with pop-up window behavior to cause this?

ibhagwan commented 1 year ago

FYI, just implemented a one liner workaround to make fzf-lua work in VimR, update to the latest fzf-lua commit and add to your config:

-- make sure “nvim” is a valid neovim shell binary
vim.env.FZF_LUA_NVIM_BIN="nvim"

For more info: https://github.com/ibhagwan/fzf-lua/issues/651#issuecomment-1435087945