qvest-digital / loginsrv

JWT login microservice with plugable backends such as OAuth2, Google, Github, htpasswd, osiam, ..
MIT License
1.92k stars 150 forks source link

WIP: Build on arm64 too #153

Closed kernle32dll closed 4 years ago

kernle32dll commented 4 years ago

Well, it would be cool to have an arm64 docker image. That could e.g. allow loginsrv to run on an raspberry pi.

This is an WIP PR to get the travis build running.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 91.734% when pulling ce27ca569ab296ce90da939523cbcf75b5fd11d8 on kernle32dll:build-arm into be2ae2ce04f3f9e5287e78121636134cc49b2fa2 on tarent:master.

kernle32dll commented 4 years ago

Hi, @J-Rocke @smancke @gereons

I wanted to kick off discussion if it would be worthwhile to provide an ARM64 Docker image of loginsrv.

At home, we have devices like the Raspberry Pi et all.. In the enterprise segment, we not only start to see cheap ARM based bare-metal servers, but also more and more cloud offerings, e.g. in AWS.

This PR proves that loginsrv builds flawlessly with ARM64. Next step would be to adjust the push pipeline, to build a multi-plattform image.

g-w commented 4 years ago

Hello @kernle32dll, currently it is out of our scope to support arm64. Beside compiling the binaries for arm64, we have to maintain the software for the architecture and be able to fix bugs. Currently nobody in our team regularly uses golang on arm64 and hence we are not able to support the development.

Feel free to build your own arm64 images and publish them. But we won't.

Kind regards, Gregor