search

qvest-digital / loginsrv

JWT login microservice with plugable backends such as OAuth2, Google, Github, htpasswd, osiam, ..
MIT License
1.92k stars 148 forks source link

Add new provider - SAML via Azure AD #169

Closed greenpau closed 4 years ago

greenpau commented 4 years ago

Resolves: #168

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-7.3%) to 84.116% when pulling 41b7183d5be254e4ef34556a5d252a767d93a485 on greenpau:samlprovider into b759a6a898f1fb50c613bf0879d5ab7a2bad6e6f on tarent:master.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 91.423% when pulling b6c0685d8233d17fbd72ba6a3cc8daa572ac749a on greenpau:samlprovider into b759a6a898f1fb50c613bf0879d5ab7a2bad6e6f on tarent:master.

greenpau commented 4 years ago

@smancke , qq, I create a doc for SAML provider here.

Should I put SAML provider documentation in a separate file or should I keep it in the main README.md?

I am documenting the work first, then I will put the necessary code together.

g-w commented 4 years ago

Hello @greenpau,

thank you for your contribution!

For now simply put the documentation in the README.md.

greenpau commented 4 years ago

@g-w , could you please review the addition. I know that the coverage is not there. I would like to get general agreement on the proposal. Once finalized, I will improve the coverage.

greenpau commented 4 years ago

@g-w , any feedback?

g-w commented 4 years ago

Hello @greenpau,

sorry for the delays, but since we are currently not using azure and i am not familiar with it, hence reviewien the changes is a bigger task. I will come back to in the next days.

greenpau commented 4 years ago

moved it to a new caddy v2 module https://github.com/greenpau/caddy-auth-forms