search

qvest-digital / terraform-kubernetes-alb-ingress-controller

Terraform module to ease deployment of the AWS ALB Ingress Controller
https://registry.terraform.io/modules/iplabs/alb-ingress-controller/kubernetes/
Mozilla Public License 2.0
57 stars 66 forks source link

[Feature Request] Support alb-ingress-controller v2.x.x #11

Open peimanja opened 3 years ago

peimanja commented 3 years ago

alb-ingress-controller v2 has released.

mogul commented 3 years ago

I've implemented this in https://github.com/iplabs/terraform-kubernetes-alb-ingress-controller/pull/13

headcr4sh commented 3 years ago

Thanks for the work, @mogul!

Support for the new AWS Ingress Controller that I am looking forward to and it's definitely on my wishlist.

I think it doesn't make sense though, to create a new Github repository (terraform-kubernetes-aws-ingress-controller) to reflect the changes in the upstream software package. I will therefore not merge your pull request into this repository, because I feel that a new repository would be the better fit.

I am also not quite sure if Helm is the way to go here and I am right now thinking about using the new kubernetes-alpha provider plugin (which will eventually be merged back into the stable kubernetes provider plugin). I am not quite sure about the pros and cons at this point and will have to think a bit before making a quick decision.

mercuriete commented 3 years ago

@mogul I am trying your repo and you forgot to add alb_controller_depends_on = something

In the snippet example inside the README.md

so your PR doesn't work using the example which is bad.

BTW, I can't open issues on this repo: https://github.com/GSA/terraform-kubernetes-aws-load-balancer-controller so, please open the possibility to report issues because I don't want to pollute this issue.

Thank you very much @mogul