qw123wh / Aospdeskclock

Fork of aosp deskclock: alarm,clock, timer,stopwatch
Apache License 2.0
52 stars 9 forks source link

[Feature request] Adjustable alarm notification offsets #8

Open ZacharyTalis opened 3 years ago

ZacharyTalis commented 3 years ago

Priority: Low, don't worry too hard about it

Background: deskclock/provider/AlarmInstance.java declares constants LOW_NOTIFICATION_HOUR_OFFSET and HIGH_NOTIFICATION_MINUTE_OFFSET. These values determine the "offset from alarm time to show" low and high priority notifications, respectively.

Request: Allow users to adjust these two values from the Settings page. I'd implement this feature myself if I had the coding chops :(

Your fork is excellent btw, thanks for making it <3

qw123wh commented 3 years ago

if i could i would, i'm not a developer, i created a fork already done, and i added some commits (power off alarm) by copying and pasting from lineageos clock aosp (it's pretty much the same). I hope someday someone will create another fork and update it

ZacharyTalis commented 3 years ago

gotchaaa, thanks for the heads-up my partner might tackle this feature request someday, we'll see

eml-lopez commented 3 years ago

Hello!

I have tested your alarm application and it works perfectly with the Evolution X ROM (Android 10) on a Leeco C106 phone, with Snapdragon 652. However with another phone I have Realme X (RMX1901), with Snapdragon 710, with PixelPlusUI ROM ( Android 11), the application does not work.

Take this opportunity to congratulate you on your great work, because it seems to me a very useful application, since no custom ROM offers the possibility of setting an alarm that works with the phone turned off.

qw123wh commented 3 years ago

@eml-lopez maybe it's a custom rom problem

qw123wh commented 3 years ago

@ZacharyTalis @eml-lopez switch to the new updated app https://github.com/qw123wh/new-clock/releases/tag/1.0

ZacharyTalis commented 3 years ago

Thank you!! <3

I see you're porting these old issues to the new repo. Once you do that here, you can close this older issue.

eml-lopez commented 3 years ago

Okay. Thanks!

I have tried your new app, but it still does not work on Android 11 with Snapdragon 710

qw123wh commented 3 years ago

@eml-lopez open a new issue on the new app, then we will continue there