search

qw123wh / new-clock

The best clock app there is
Apache License 2.0
79 stars 27 forks source link

change code base from Java to Kotlin #17

Open sanpei3 opened 2 years ago

sanpei3 commented 2 years ago

The latest AOSP deskclock is written in Kotlin. Do you have any plan to change the codebase from Java to Kotlin?

Currently, I'm working with Kotlin and I extended some features("exclude holiday" alarm time, selectable alarm notification) https://github.com/sanpei3/new-clock (build environment is based from qw123wh/newclock, codebase from Kotlin/AOSP deskclock).

qw123wh commented 2 years ago

Hi I noticed your fork, it's very interesting, I was thinking of converting the code to Kotlin, but I want to make sure that the “power off alarm” feature also works with the conversion to Kotlin. Other features are also to be tested and you have to see if I also encounter any errors in the compilation phase

sanpei3 commented 2 years ago

That's sounds good. I will test your branch and I will create pull requests. If you create a test branch, please let me know.

kia1349 commented 2 years ago

There are many similar programs on the Internet with Kotlin language. But this is the best open source program written in Java. Please do not switch to Kotlin .

qw123wh commented 2 years ago

@kia1349 My intention is not to delete the java version, but to create another kotlin branch. However I haven't had time to create the kotlin branch yet. When I have created the kotlin branch I will notify @sanpei3

kia1349 commented 2 years ago

🙏👍 thanks