qwat / QWAT

TEKSI Water module (project QWAT) - QGIS project
https://www.teksi.ch
GNU General Public License v2.0
58 stars 31 forks source link

Add to the qgs project the ouvrages_polygon layer #202

Closed tudorbarascu closed 7 years ago

tudorbarascu commented 7 years ago

Hi,

On my localized project we're using another layer named ouvrages_polygon (translated) which is the same as ouvrages except it points to the polygon_geometry.

I would like to at this to our baseline project.

Do others use the polygon_geometry? Opinions?

haubourg commented 7 years ago

As long as it shows a QWAT hidden capability, I'm +1 in exposing it.
We need to add geometries examples to the data sample dumps. Could you add here some realistic screenshots so that I know what kind of drawing can be expected and push some in the dataset ?

@3nids do you use that geometry?

tudorbarascu commented 7 years ago

For a water-flow meter installation (chambre debitmetre), you can describe it as a point but you can also describe the installation polygon (boundaries).

See a QWC2 gif where you can see the installation chamber, the point representing the flow-meter and also the cover (couvercle) in the bottom right corner of the polygon. Of course, you can also see the valves, pipes etc.

demo

haubourg commented 7 years ago

@tudorbarascu @3nids while on it, I see no trigger to initialize the geom_polygon of installation when creating a new element. How do you handle the creation of a geometry on an existing point with NULL geometry? I tried the "add part" edit tool with no result and failures inside the DB logs related to audit trigger and NULL hstore (v 1.2.6).

Should we add a layer action to initialize a polygon geometry (making a square buffer of 5 m for instance) and then let the user modify it?

tudorbarascu commented 7 years ago

We always add a point installation before making use of the addpart tool and create the polygon geometry.

I would prefer not to automatically generate the polygon as I wouldn't want map users forgetting on how the polygon was created and taking it for real. We could mitigate this with styling (e.g. generated polygons with that exact geometry would be in a specific named group etc.). However, maybe somebody forgets this database side and starts doing some reports based on those.

I think adding a "Describe installation polygon" action that would start the Addpart tool on that exact feature would improve the work-flow quite a bit.

tudorbarascu commented 7 years ago

@haubourg Whoops, that's what you proposed. Yes.. that's what we want. Doh...

haubourg commented 7 years ago

We always add a point installation before making use of the addpart tool and create the polygon geometry.

Ok then something is broken in my install, either 2.18.10 or DB trigger chain doing things wrong

adding a "Describe installation polygon" action that would start the Addpart tool on that exact feature would improve the work-flow quite a bit.

agreed fully. Issue filed here : #204

tudorbarascu commented 7 years ago

@haubourg cool. then something is broken in my install I just tested with the latest data model and it works.

ponceta commented 7 years ago

This is used in Pully as well, should be in the demo project.