Important bug on reshape tool - QGIS 2.18.12

dsavary commented 7 years ago

You can extend a 3d line with the reshape tool (remodeler une entité) by snapping on endpoints. But, when you extend a 3d line by snapping on the end vertex of the line, the 3d new vertex take the value "Nan" , not very good but ok. It would be better 0 ... However, when you extend a 3d line by snapping on the start vertex of the line, we cann't see the Z coordinate with node tool ?? and the worst after saving the feature, every vertex take 0 at the z coordinate ?? Is it possible to fix this bug as soon as possible for QGIS 2.18 ? Demo Gif : https://share.oslandia.net/public/f19e52

haubourg commented 7 years ago

Hi Daniel,

extends with reshape tool adds nan values to Z: I confirm that, but that's not a bad behavior in 2.18 context since all we did with default z values fell in 2.99 only. 0 is not better as all discussions with core dev's led to dealing with Nan in QGIS and not 0 for no value (was planned but rejected by NextGIS). This map tool may be the only one to behave correctly in fact.
Converting to 0 and seeing a "r" column in node tool editor as seen in your gif doesn't happen to me with a Geopackage dataset. What datasource format are you using ?

dsavary commented 7 years ago

Hi Regis,

Ok for the first point.
Tested with datasource format SHP and POSTGIS

haubourg commented 7 years ago

Tested with shp and confirmed, all z and m are reset by reshape tool. Strange that this is provider dependant. I'll look into redmine to seek for similar issues

haubourg commented 7 years ago

Ticket filed here : https://issues.qgis.org/issues/17118

haubourg commented 7 years ago

@dsavary Do you think it is a regression? I never tested that before.

dsavary commented 7 years ago

@haubourg I don't know. I also never tested that before. Do you think that this bug can be still fix for QGIS 2.18 ?

haubourg commented 7 years ago

2.18 has a point release every month until 3.2 becomes LTR, so yes. 2.18.13 will be packed within a week and we don't have enough ressources for that. (Paul is in vacation) The the main effort will be put into 3.0 feature and fixes. For 2.18.14 to be released mid october, I think we can make it, but we can't evaluate the cost before trying to fix it.

dsavary commented 7 years ago

Ok for 2.18.14 . I think that the QWAT group can pay to fix this. :) ? A good tool to extend a 3d line is very important to manage a network... Or Perhaps, we can do a plugin "extend a 3d line with snapping points"

ponceta commented 7 years ago

As said by PSC on monday 25.09.2017, this is considered as bug and should be fixed asap.

ponceta commented 7 years ago

reshape_tool

NaN for newly created vertex is fine but losing existing Z value on node is a pity.

Tested on qwat pipe layer on postgres.

haubourg commented 7 years ago

@pblottiere if you have some time left, can you try to fix that? Please assign yourself to this ticket and in https://issues.qgis.org/issues/17118

haubourg commented 7 years ago

fixed in master QGIS3 Backport in 2.18 started

pblottiere commented 7 years ago

PR is merged is 2.18 : https://github.com/qgis/QGIS/pull/5349.

Let me know!

haubourg commented 7 years ago

@savary can you test if release nightlies are good to you?

savary commented 7 years ago

I think I was added to this post by mistake. Don't you mean someone else?

haubourg commented 7 years ago

@savary, sorry yes, I meant to ping @ponceta. But your tests are welcome too.

dsavary commented 7 years ago

@haubourg my profile name is @dsavary and not "savary" . Sorry :)

dsavary commented 7 years ago

@pblottiere @haubourg Tested with QGIS 2.18

Extend at the ends (begin/end) of a line without snapping 3d points take z = 0 for each vertex : yes, it s work , good
Extend at the ends (begin/end) of a line with snapping 3d points take the z of "snapping" points for each vertex : yes, it s work, very good !
extend from the start vertex (vertex = 0) of a line and snapping at the end vertex of another line. The two line extend until the snaping vertex : strange behavior ? Test on postgis 3d layer .

a demo example : reshape_tool_extend_begin_ends

haubourg commented 6 years ago

@Paul, could you throw an eye on the last issue found by @dsavary ?

haubourg commented 6 years ago

PR for master here https://github.com/qgis/QGIS/pull/5780

pblottiere commented 6 years ago

I'm waiting for a review before doing the backport.

pblottiere commented 6 years ago

PR for master has been merged. I'm working on the backport now.

dsavary commented 6 years ago

Good news thanks. Tell me when I can test.

dsavary commented 6 years ago

This bug fix is included in the last QGIS version 2.18.15 ?

pblottiere commented 6 years ago

This bug fix is included in the last QGIS version 2.18.15 ?

Not yet, I just made the backport.

pblottiere commented 6 years ago

Backport is merged.

dsavary commented 6 years ago

tested with 2.18.16 , ok . We can close this issue :) Thanks Paul

qwat / QWAT

Important bug on reshape tool - QGIS 2.18.12 #221