search

qwat / QWAT

TEKSI Water module (project QWAT) - QGIS project
https://www.teksi.ch
GNU General Public License v2.0
58 stars 31 forks source link

Chain filters cannot select NULL values #237

Closed tudorbarascu closed 3 years ago

tudorbarascu commented 6 years ago

When using chain filters, it's not possible to select a material that has a NULL diameter.

This means the "Other", "Unknown", "To be determined" values and all the materials without Diameter cannot be selected.

The combinations between material and NULL diameter are unique, so it should have worked.

bug

A solution is to add empty string in the Diameter part and the user can select the empty string. I can make a pull request in the data model but I think this should be fixed in the widget.

haubourg commented 6 years ago

@pblottiere any opinion here?

3nids commented 6 years ago

I think it's a good solution to add empty or strings like "unknown" in diameter column. There is already on unknow diameter per material type to handle such situations.

ponceta commented 4 years ago

@tudorbarascu Have you tried it on 3.10.3? Is it still disfunctionning?

We are currently pushing for a great amount of corrections for the relationnal widget and chain filters.

Much has been done by @troopa81 on https://github.com/qgis/QGIS/pull/34943

We still need more testing on future 3.10.4 and master

ponceta commented 4 years ago

3.14.0 seems to fix this, as soon as you have a valid Null diameter entity for your material :

Materials

Otherwise it will take the first diameter available (that's why a check that every material has a Null diameter instance should be checked)

ponceta commented 3 years ago

@tudorbarascu this seems to be solved to me, please feel to reopen if needed.