qwat / QWAT

TEKSI Water module (project QWAT) - QGIS project
https://www.teksi.ch
GNU General Public License v2.0
57 stars 31 forks source link

Valve symbology #30

Open tudorbarascu opened 9 years ago

tudorbarascu commented 9 years ago

Hi,

As in nodes, there is also a need of drawing the valve with respect to the pipe orientation.

Also, I feel that we should use standard symbols for depicting valves (I think you're not using standard Swiss ones, do you?). See https://www.edrawsoft.com/images/shapes/pfd-valves.png

Opinions?

3nids commented 9 years ago

Hi, The thig is that we don't have nodes under the valves as they're not supposed to be at one end of a pipe. Although, we could make a small function to calculate the orientation of the pipe under the valve and write this angle.

These are detailed icons. I think the standard one in Switzerland is a circle with a line crossing it.

tudorbarascu commented 9 years ago

I know they're detailed. As I was looking at other GIS/Hydraulic water software and I noticed all of them got similar valves symbols as in the link above, I got the idea that having valve specific standard symbols somewhere in the future would enable easier migration for other users.

haubourg commented 7 years ago

Hi, I just worked in that area. I agree current symbols could be improved. On another wastewater project, we have users setting rotation manually on all valves or nodes, with the rotation tool. See the snapshot here. Computing it on the fly could be an optiont too but might be strange in some cases such as angles or crowded zones. image We currently face issues when features are overlapping, current rotation tool Would that be an option?

haubourg commented 7 years ago

@tudorbarascu Hi Tudor, trying to cleanup issues. Is that still up to date?

tudorbarascu commented 7 years ago

Hi Regis. I'm using just one symbol for valves. The reason I opened this issue is to try and make everything more towards international way of symbolizing things. So, for me, it's important to have symbols that many use although keeping just one symbol doesn't touch me. I would say this issue is up to date if we want to reach to many others that have used or are using these symbols.

This issue is about symbology but I would have also liked a better classification of the valves. We always postponed it but it should be done.

haubourg commented 7 years ago

Ok, keeping it open, thanks